HazardyKnusperkeks added a comment.

Look good in general, only the few comments.



================
Comment at: clang/unittests/Format/FormatTest.cpp:8892
   FormatStyle Style = getLLVMStyle();
+  FormatStyle NoEmptyLines = getLLVMStyle();
+  NoEmptyLines.MaxEmptyLinesToKeep = 0;
----------------
While we are at empty lines, maybe add some here, so that it is a bit more 
readable. It took me some time to see that you use 2 different styles.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99503/new/

https://reviews.llvm.org/D99503

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to