aaron.ballman added a comment.

Thank you for the patch! Btw, can you add more context to the patch when you 
generate it (I usually use `-U 999` when making patches)?

The changes look good so far, but I think `docs\ClangPlugins.rst` should be 
updated to document the new functionality and it would be nice to add example 
usage (in lieu of tests) to `examples\Attribute`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99877/new/

https://reviews.llvm.org/D99877

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to