[PATCH] D100120: [RISCV][Clang] Add all RVV Mask intrinsic functions.

[Craig Topper via Phabricator via cfe-commits]

craig.topper added a comment.

LGTM other than that inheritance question



================
Comment at: clang/include/clang/Basic/riscv_vector.td:247
+                            list<list<string>> suffixes_prototypes> {
+  defm "" : RVVBuiltinSet<intrinsic_name, type_range, suffixes_prototypes, 
[-1]>;
+}
----------------
Can we use inheritance here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100120/new/

https://reviews.llvm.org/D100120

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits