[PATCH] D99969: [OpenCL] Accept .rgba in OpenCL 3.0

[Anton Zabaznov via Phabricator via cfe-commits]

azabaznov added a comment.

Thanks for working on this! Looks good to me in general. I have a small comment.



================
Comment at: clang/lib/Sema/SemaExprMember.cpp:343
     if (HasRGBA || (*compStr && IsRGBA(*compStr))) {
-      if (S.getLangOpts().OpenCL && S.getLangOpts().OpenCLVersion < 220) {
+      if (S.getLangOpts().OpenCLVersion < 300) {
         const char *DiagBegin = HasRGBA ? CompName->getNameStart() : compStr;
----------------
Did you forget to check for OpenCL first (`S.getLangOpts().OpenCL`)?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99969/new/

https://reviews.llvm.org/D99969

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits