tra added a comment. Still LGTM.
================ Comment at: clang/test/Driver/hip-code-object-version.hip:24-39 // Check bundle ID for code object v2. // RUN: %clang -### -target x86_64-linux-gnu \ // RUN: -mno-code-object-v3 \ // RUN: --offload-arch=gfx906 -nogpulib \ // RUN: %s 2>&1 | FileCheck -check-prefixes=V2,V2-WARN %s ---------------- Nit: it would be nice to move V2 tests above the V3, so the tests are in order. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99235/new/ https://reviews.llvm.org/D99235 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
