This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. jcai19 marked an inline comment as done. Closed by commit rG3cc3c0f8352e: Add support to -Wa,--version in clang (authored by jcai19).
Changed prior to commit: https://reviews.llvm.org/D99556?vs=334315&id=334558#toc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99556/new/ https://reviews.llvm.org/D99556 Files: clang/lib/Driver/ToolChains/Clang.cpp clang/test/Driver/as-version.s Index: clang/test/Driver/as-version.s =================================================================== --- /dev/null +++ clang/test/Driver/as-version.s @@ -0,0 +1,9 @@ +// Test version information. + +// RUN: %clang -Wa,--version -c -fintegrated-as %s -o /dev/null \ +// RUN: | FileCheck --check-prefix=IAS %s +// IAS: clang version + +// RUN: %clang -Wa,--version -c -fno-integrated-as %s -o /dev/null \ +// RUN: | FileCheck --check-prefix=GAS %s +// GAS-NOT: clang Index: clang/lib/Driver/ToolChains/Clang.cpp =================================================================== --- clang/lib/Driver/ToolChains/Clang.cpp +++ clang/lib/Driver/ToolChains/Clang.cpp @@ -2549,6 +2549,8 @@ // -fdebug-compilation-dir (without '=') here. CmdArgs.push_back("-fdebug-compilation-dir"); CmdArgs.push_back(Value.data()); + } else if (Value == "--version") { + D.PrintVersion(C, llvm::outs()); } else { D.Diag(diag::err_drv_unsupported_option_argument) << A->getOption().getName() << Value;
Index: clang/test/Driver/as-version.s =================================================================== --- /dev/null +++ clang/test/Driver/as-version.s @@ -0,0 +1,9 @@ +// Test version information. + +// RUN: %clang -Wa,--version -c -fintegrated-as %s -o /dev/null \ +// RUN: | FileCheck --check-prefix=IAS %s +// IAS: clang version + +// RUN: %clang -Wa,--version -c -fno-integrated-as %s -o /dev/null \ +// RUN: | FileCheck --check-prefix=GAS %s +// GAS-NOT: clang Index: clang/lib/Driver/ToolChains/Clang.cpp =================================================================== --- clang/lib/Driver/ToolChains/Clang.cpp +++ clang/lib/Driver/ToolChains/Clang.cpp @@ -2549,6 +2549,8 @@ // -fdebug-compilation-dir (without '=') here. CmdArgs.push_back("-fdebug-compilation-dir"); CmdArgs.push_back(Value.data()); + } else if (Value == "--version") { + D.PrintVersion(C, llvm::outs()); } else { D.Diag(diag::err_drv_unsupported_option_argument) << A->getOption().getName() << Value;
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits