Re: [PATCH] D19780: Output OpenCL version in Clang diagnostics

[Anastasia Stulova via cfe-commits]

Anastasia added inline comments.

================
Comment at: lib/Parse/ParseDecl.cpp:3519
@@ +3518,3 @@
+                                               / 100);
+        const char *VerSpec = (VerMajor + std::string (".") + 
VerMinor).c_str();
+        Diag(Tok, DiagID) << VerSpec << PrevSpec << isStorageClass;
----------------
I think it will be nicer to use string (not char*) here too.


http://reviews.llvm.org/D19780



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits