AntonBikineev marked an inline comment as done.
AntonBikineev added inline comments.


================
Comment at: clang/lib/Frontend/InitPreprocessor.cpp:593-594
+  // C++2b features.
+  if (LangOpts.CPlusPlus2b)
+    Builder.defineMacro("__cpp_size_t_suffix", "202011L");
   if (LangOpts.Char8)
----------------
aaron.ballman wrote:
> Because we allow this as an extension in all C++ modes, should this be 
> enabled always rather than gated on C++2b?
I was also wondering about this. I've checked that we also do the same for 
other feature macros, such as __cpp_binary_literals, which is defined for 
-std>=c++14 while at the same time is allowed as an extension before C++14. 
Therefore I decided to mimic the behaviour.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99456/new/

https://reviews.llvm.org/D99456

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to