bkramer added inline comments. ================ Comment at: include-fixer/find-all-symbols/FindAllSymbols.h:16 @@ +15,3 @@ +#include "llvm/ADT/StringRef.h" + +#include <map> ---------------- No space between #includes in LLVM.
================ Comment at: include-fixer/find-all-symbols/PragmaCommentHandler.cpp:27 @@ +26,3 @@ + SmallVector<StringRef, 4> Matches; + if (!llvm::Regex(IWYUPragma).match(Text, &Matches)) + return false; ---------------- Isn't this regex just a complex way to write Text.find(IWYUPragma)? http://reviews.llvm.org/D19816 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits