hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land.
LGTM with one nit. ================ Comment at: test/clang-tidy/google-default-arguments.cpp:10 @@ +9,3 @@ + void f(int I, int J = 5); + // CHECK-MESSAGES: :[[@LINE-1]]:8: warning: default arguments on virtual or override methods are prohibited [google-default-arguments] +}; ---------------- You can remove the `[google-default-arguments]` in this line and `line 15`. Usually we only keep it on the first warning message. http://reviews.llvm.org/D19534 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
