steveire added inline comments.
================ Comment at: flang/cmake/modules/CMakeLists.txt:15 # Generate FlangConfig.cmake for the build tree. +include(CMakePackageConfigHelpers) + ---------------- Instead of including this multiple times, please add it to `AddLLVM.cmake`. That file is used in project top-level builds too and it already contains other includes needed in the build. It is installed, but only for the purpose of building other parts of LLVM, so it's not a concern for third parties either (It is not included by `LLVMConfig.cmake`). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97513/new/ https://reviews.llvm.org/D97513 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
