[PATCH] D99008: [RISCV] [2/2] Add intrinsic for Zbr extension

[Craig Topper via Phabricator via cfe-commits]

craig.topper added inline comments.


================
Comment at: clang/lib/Headers/riscv_zbr_intrin.h:9
+ */
+
+#ifndef __RISCV_ZBR_INTRIN_H
----------------
Please add 

```
#ifndef __RVINTRIN_H                                                            
                                                                                
                                                                                
                                  
#error "Never use <riscv_zbr_intrin.h> directly; include <rvintrin.h> instead."
#endif 
```

This file doesn't work if you include it by itself because it references 
int_xlen_t and __DEFAULT_FN_ATTRS which aren't defined in this file.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99008/new/

https://reviews.llvm.org/D99008

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits