martong marked an inline comment as done.
martong added a comment.

Thanks for the review!



================
Comment at: clang/lib/StaticAnalyzer/Core/SimpleSValBuilder.cpp:655
         return makeSymExprValNN(op, InputLHS, InputRHS, resultTy);
+      case BO_Div:
       case BO_Rem:
----------------
vsavchenko wrote:
> I think we should either add: `// 0 / x == 0` or modify the comment for 
> `BO_Rem`
Okay, I added the new comment.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99343/new/

https://reviews.llvm.org/D99343

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to