abhina.sreeskantharajan added a comment. In D97785#2650824 <https://reviews.llvm.org/D97785#2650824>, @yroux wrote:
> Hi Abhina, > > I think this patch broke Windows on ARM bots, the first failure observed 6 > days ago in this build: > > https://lab.llvm.org/buildbot/#/builders/65/builds/1245 > > I don't really get what the problem is, but the issue is related to > tablegen generated file AbstractTypeReader.inc and your patch is the only > one in the set which is touching that area. > > Does it ring a bell for you ? > > Cheers, > Yvan Hi, thanks for bringing this to my attention. Since only Windows seems to have this error, it may be caused by my patch. I suspect that setting OF_None flag/Binary mode for Windows in getFile() should fix it if that is the case. I'll work on a patch to hopefully fix the issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97785/new/ https://reviews.llvm.org/D97785 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
