abhina.sreeskantharajan added a comment.
In D96363#2650460 <https://reviews.llvm.org/D96363#2650460>, @aganea wrote:
> Hello! This patch breaks compilation when using `-frewrite-includes` on
> Windows. It adds an extra line with CRLF, which causes compilation failures
> with macros line-breaks:
>
> $ cat -A hello.cpp
> int foo();^M$
> int bar();^M$
> #define HELLO \^M$
> foo(); \^M$
> bar();^M$
> ^M$
> int main() {^M$
> HELLO^M$
> return 0;^M$
> }
> $ clang-cl /E -Xclang -frewrite-includes hello.cpp > test.cpp
>
> $ cat -A test.cpp
> # 1 "<built-in>"^M^M$
> # 1 "hello.cpp"^M^M$
> int foo();^M^M$
> int bar();^M^M$
> #define HELLO \^M^M$
> foo(); \^M^M$
> bar();^M^M$
> ^M^M$
> int main() {^M^M$
> HELLO^M^M$
> return 0;^M^M$
> }^M^M$
>
> $ clang-cl /c test.cpp
> hello.cpp(8,3): error: C++ requires a type specifier for all declarations
> foo(); \
> ^
> hello.cpp(10,3): error: C++ requires a type specifier for all declarations
> bar();
> ^
> 2 errors generated.
>
> $ clang-cl /c hello.cpp
>
> $
>
> @abhina.sreeskantharajan would you have a chance to take a look please?
Sure, let me take a look. This change should be non-functional so there might
be a function usage I missed somewhere.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D96363/new/
https://reviews.llvm.org/D96363
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
