steakhal added a comment.

I recommend splitting this into two. I would happily accept the part about 
`std::data()`.

IMO `std::addressof()` should be modelled via `evalCall` as a pure function, 
instead of hacking it into the `InnerPtrChecker`.
It is overloaded to accept `const T&` as well, so the comment about 
//"std::addressof function accepts a non-const reference as an argument"// is 
not entirely true.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99260/new/

https://reviews.llvm.org/D99260

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to