RedDocMD marked an inline comment as done.
RedDocMD added inline comments.
================
Comment at: clang/test/Analysis/smart-ptr-text-output.cpp:317
void getShouldNotAlwaysLeaveANote() {
std::unique_ptr<A> P; // expected-note {{Default constructed smart
pointer 'P' is null}}
----------------
NoQ wrote:
> Looks like your git history is acting up. Your patch adds this test right?
> Are there more proposed changes in the cpp files that aren't currently
> highlighted for a similar reason?
>
> I'll try to play with your patch locally once this is fixed ^.^
Yeah I seem to have tripped over the single commit rule. It should be fixed now.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D97183/new/
https://reviews.llvm.org/D97183
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
