awarzynski accepted this revision. awarzynski added a comment. This revision is now accepted and ready to land.
LGTM, thank you for working on this! In the summary you refer to `-fdebug-module-writer`. Could you please update before merging this? ================ Comment at: flang/lib/Frontend/CompilerInvocation.cpp:323 + // Prepend the ordered list of -intrinsic-modules-path + // to the default location to search (currently hardcoded). + for (const auto *currentArg : ---------------- [nit] To me, `currently hardcoded` suggests that it's a temporary solution. But that's not the case, is it? Also, the default location is relative to the location of the driver, so it's not hardcoded. ================ Comment at: flang/lib/Frontend/CompilerInvocation.cpp:26 #include "llvm/Support/raw_ostream.h" + +#include "llvm/Support/FileSystem.h" ---------------- awarzynski wrote: > Not needed Please revert before merging. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97080/new/ https://reviews.llvm.org/D97080 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
