awarzynski added inline comments.
================ Comment at: flang/test/Driver/std2018.f90:1 +! REQUIRES: new-flang-driver +! Ensure argument -std=f2018 works as expected. ---------------- arnamoy10 wrote: > awarzynski wrote: > > Would it be possible to share this test with `f18`? > Would you please elaborate on how do want the sharing to happen (same test > file/different test file)? I think in a previous comment you mentioned that > it is sufficient to test the frontend driver for this patch? This line means that the test is not run when `FLANG_BUILD_NEW_DRIVER` is `Off`: ``` ! REQUIRES: new-flang-driver ``` Once this line is removed, the test is effectively shared. Currently this test won't work with `f18`(i.e. when you remove this line), but is should be sufficient to add `-pedantic` and `-std=f2018` as aliases for [[ https://github.com/llvm/llvm-project/blob/987ee6e3cc1fb672b3ed201e72a5281c2ec88c99/flang/tools/f18/f18.cpp#L489-L491 | Mstandard ]]. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97119/new/ https://reviews.llvm.org/D97119 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
