mstorsjo added a comment. In D98278#2637866 <https://reviews.llvm.org/D98278#2637866>, @zero9178 wrote:
> In D98278#2637826 <https://reviews.llvm.org/D98278#2637826>, @mstorsjo wrote: > >> Btw, while this change does explain _what_ it does, it doesn't actually say >> the exact reason _why_. Cleanliness? Sure, that's nice... Or is it a case >> where e.g. some translations produce different error messages? > > Now that you mention it, it's indeed not as clear as I thought. But yes, in > the case of MSVCs STL, the messages from `std::error_codes` which are used by > various LLVM tools produce different strings then using `strerror` (the C > function also called by Python) with the same error codes (Specifically, it > has different casing). Ok, but would e.g. a case insensitive comparison have worked instead of this? And didn't the python script have hardcoded strings, specifically for the MSVC case? Why weren't they written with the right casing for the case that they're supposed to match? I.e. was it an issue with the existing hardcoded strings, or did they work in one case but not another one? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98278/new/ https://reviews.llvm.org/D98278 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
