aaron.ballman marked an inline comment as done.
aaron.ballman added inline comments.
================
Comment at: clang/unittests/Frontend/CompilerInvocationTest.cpp:547
TEST_F(CommandLineTest, ConditionalParsingIfTrueFlagNotPresent) {
const char *Args[] = {"-fsycl"};
----------------
jansvoboda11 wrote:
> This test originally checked that enabling SYCL without specifying the
> version is fine and results in `LangOptions::SYCL_None`.
>
> I'd like to keep the semantics of this test intact (it exercises the
> underlying tablegen machinery of `ShouldParseIf`).
>
> I suggested only replacing `-fsycl` with `-fsycl-is-host` here and in the
> assert below.
Thank you for the suggestions, I've applied them.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D97717/new/
https://reviews.llvm.org/D97717
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
