aaron.ballman added inline comments.
================ Comment at: clang-tools-extra/clang-tidy/bugprone/EasilySwappableParametersCheck.cpp:707-708 + // FIXME: Don't emit multiple combinations here either. + StringRef DiagText = "a call site binds an expression to '%0' and " + "'%1' with the same force"; + diag(M.Second->getOuterLocStart(), DiagText, DiagnosticIDs::Note) ---------------- I think "with the same force" is going to be hard for users to make sense of. I'm at a bit of a loss for how to word it though. The issue is that `T` and `const T&` parameters *might* be easily swapped, so maybe it's best to call it out that way? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95736/new/ https://reviews.llvm.org/D95736 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
