balazske added a comment.

Looks good, just find a better place for the test.



================
Comment at: clang/unittests/AST/ASTImporterTest.cpp:817
 
+TEST_P(ImportDecl, ImportedVarDeclPreservesThreadLocalStorage) {
+  MatchVerifier<Decl> Verifier;
----------------
The test can be moved to better place, probably after line 3481 and use 
`ImportVariables`. At least I want it not between two related tests, here 
between `ImportUsingDecl` and `ImportUsingShadowDecl`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98707/new/

https://reviews.llvm.org/D98707

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to