qiucf added inline comments.
================ Comment at: clang/bindings/python/clang/cindex.py:2061-2062 TypeKind.FLOAT128 = TypeKind(30) TypeKind.HALF = TypeKind(31) +TypeKind.IBM128 = TypeKind(32) TypeKind.COMPLEX = TypeKind(100) ---------------- hubert.reinterpretcast wrote: > This looks suspiciously like the result of this file having not been > maintained for the additions of: > ``` > CXType_Float16 = 32, > CXType_ShortAccum = 33, > CXType_Accum = 34, > CXType_LongAccum = 35, > CXType_UShortAccum = 36, > CXType_UAccum = 37, > CXType_ULongAccum = 38, > CXType_BFloat16 = 39, > ``` > > What test coverage fails if the addition of `TypeKind.IBM128` is omitted from > this patch? Change this to `40` for consistency. Actually I did not get any failure of `check-clang` even when removing all these floating point types assignment. Test coverage may miss here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93377/new/ https://reviews.llvm.org/D93377 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
