jdoerfert added a comment. In D94741#2624475 <https://reviews.llvm.org/D94741#2624475>, @nikic wrote:
> It looks like this has broken handling of `getelementptr %T`, and generates > `getelementptr [[T]]` for it now, see e.g. the first change in > https://github.com/llvm/llvm-project/commit/7ee96429a0b057bcc97331a6a762fc3cd00aed61. I don't see the problem: Source is `...(%ABC, %ABC, ...` Before we checked: `...(%ABC, [[ABC:%.*]], ...` Now we check: `...([[ABC:%.*]], [[ABC]], ...` That seems strictly better to me. What am I missing? > In > https://github.com/llvm/llvm-project/commit/6491e0165e96a93960e2dfb338c52c7eb155f408#diff-85c14e813467fc768fb641be9567780053ef1162da8cc12dd6bcb29d5e14384eR575 > I was forced to rename the function argument to avoid a clash between the > type `%S2` and the value `%s2`. Hm, this one I can see. We could work around that by looking if there is a global with the same name and then add a `_lcl` suffix. I can try to look into it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94741/new/ https://reviews.llvm.org/D94741 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
