awarzynski accepted this revision. awarzynski added a comment. Thank you for addressing my comments and for working on this! I've left one small suggestion, but that's a [nit].
================ Comment at: clang/test/Driver/cxx_for_opencl.cppcl:1 +// RUN: %clang %s -Xclang -verify -fsyntax-only +// RUN: %clang %s -cl-std=clc++ -Xclang -verify -fsyntax-only ---------------- This is a very neat test. Would it make sense to add something more basic too? For example (in a separate file): ``` // RUN: %clang %s -fstynax-only -### | FileCheck %s // CHECK: -x -cppcl ``` This way you would have a bit more explicit test to verifiy that the compiler driver picks the right language based on the extension. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96771/new/ https://reviews.llvm.org/D96771 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
