svenvh added inline comments.
================
Comment at: clang/docs/ReleaseNotes.rst:214
+- Added ``global_device`` and ``global_host`` address spaces for USM
+ allocations.
+
----------------
Anastasia wrote:
> svenvh wrote:
> > Perhaps one more point to mention:
> > ```
> > - Allow pointer-to-pointer kernel arguments beyond OpenCL 1.2.
> > ```
> > (related commit is 523775f96742 ("[OpenCL] Allow pointer-to-pointer kernel
> > args beyond CL 1.2", 2020-12-01)).
> I have covered it in this but it is combined with another diagnostic:
>
>
> ```
> - Improved diagnostics for nested pointers and unevaluated ``vec_step``
> expression.
> ```
>
> But if you think it is better I can change as you have suggested.
Ah, that's probably why I missed it, as I was assuming "improved diagnostics"
means a nicer error message, not that Clang now accepts something that it
rejected before. So in my opinion it deserves a point on its own.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D98076/new/
https://reviews.llvm.org/D98076
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
