vsavchenko added a comment. @steakhal I personally don't see any fundamental problems with this patch
================ Comment at: clang/lib/StaticAnalyzer/Core/SValBuilder.cpp:878 + // Integer is known to be non-zero or zero only. + auto truth = State->isNonNull(V); + if (truth.isConstrained()) ---------------- nit: LLVM coding standards call for variable names starting with upper-case letters. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97874/new/ https://reviews.llvm.org/D97874 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
