delcypher added a comment. In D98291#2615593 <https://reviews.llvm.org/D98291#2615593>, @beanz wrote:
> So... this patch is fine. (marked as approved). That said, we should really > be working to remove the `LLVM_BUILD_EXTERNAL_COMPILER_RT` option entirely in > favor of just using `LLVM_ENABLE_RUNTIMES=compiler-rt`. That build process > does support invoking the sub-project build on build invocation to make sure > builds get re-run, and it supports better understanding of the dependencies > between runtimes. > > Have you considered using that instead of `LLVM_BUILD_EXTERNAL_COMPILER_RT`? @beanz It's something I've thought about but haven't had the time to do. The fact that we have 3 different ways to build compiler-rt in LLVM makes me sad. There should only be 1. I don't have time to do it now but I've filed a radar to do this work at some point (rdar://75248447). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98291/new/ https://reviews.llvm.org/D98291 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
