steveire added a comment. I like the idea, but I think you're violating the Interface Segregation Principle by putting it in the `Registry::lookupMatcherCtor` implementation. The interface here is easy to use incorrectly. Consider adding a new method instead. That way, `lookupMatcherCtor` will continue to do what it's name says it does and it will never return a "wrong" matcher. A new `lookupCloseMatch` API can be called if the optional returned by `lookupMatcherCtor` is `None`. That seems to be a more consistent API.
Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97963/new/ https://reviews.llvm.org/D97963 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
