kuzkry added a comment.

In D87587#2602523 <https://reviews.llvm.org/D87587#2602523>, 
@HazardyKnusperkeks wrote:

> In D87587#2597241 <https://reviews.llvm.org/D87587#2597241>, @kuzkry wrote:
>
>> Thank you for delivering it, @HazardyKnusperkeks.
>>
>> One thing concerns me though. I'm not an author of changes done in 
>> clang/docs/ClangFormatStyleOptions.rst in lines 2372, 3069-3073, 3075, 3077, 
>> 3082-3086, 3088, 3093-3097, 3099, 3104-3108, and 3110-3111. Perhaps it's 
>> just a mistake (something might have slipped through `git add`). Please let 
>> me know.
>
> I've just run `dump_format_style.py`, why the other lines were changed (or 
> not correct before) I don't know, but this is the result of the official 
> script.
>
> If that bothers you I can revert and split it in two commits. But I don't 
> think that's necessary as the real author of those lines is the script, not 
> what's written in the git history.

Oh, no need to do that. Thank you for your involvement in this review.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87587/new/

https://reviews.llvm.org/D87587

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to