DiggerLin marked an inline comment as done. DiggerLin added a comment.
================ Comment at: clang/lib/Frontend/CompilerInvocation.cpp:3630 + // no -fvisibility=* option. + if (T.isOSAIX() && (Args.hasArg(OPT_mignore_xcoff_visibility) || + !Args.hasArg(OPT_fvisibility))) ---------------- daltenty wrote: > No sure if we intended to move this block? Regardless, we should probably > preserve the extra comments that got added. in original patch https://reviews.llvm.org/D87451 , the -mignore-xcoff-visibility is CodeGenOpt, in the new patch, we change the option "-mignore-xcoff-visibility" as LangOpt. I will add the extra comment back. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89986/new/ https://reviews.llvm.org/D89986 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits