hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land.
Thanks! ================ Comment at: clang/test/SemaCXX/cxx1z-class-template-argument-deduction.cpp:425 + // This used to crash due to unparsed default arg above. + B(); // expected-error {{deduction guide declaration without trailing return type}} +}; ---------------- The diagnostic seems bogus, but I think it is at least better than crashing, I'd add add a FIXME to fix this bogus diagnostic here?. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97965/new/ https://reviews.llvm.org/D97965 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits