tianshilei1992 added inline comments.
================ Comment at: clang/lib/Sema/SemaDeclAttr.cpp:3679 S.Diag(AL.getLoc(), diag::err_attribute_wrong_number_arguments) - << AL << (unsigned)(EncodingIndices.size() - 1); + << AL << (unsigned)(CalleeFnProtoType->getNumParams() + 2); return; ---------------- Need to revise this line to see which is the right number passed here. ================ Comment at: llvm/include/llvm/IR/AbstractCallSite.h:55 struct CallbackInfo { + enum ParameterEncodingModeTy : int64_t { + FLATTEN = 0, ---------------- I guess this enum should be in a more common place such that other files can use it. Any suggestion? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98134/new/ https://reviews.llvm.org/D98134 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits