mstorsjo added a comment.

In D98022#2609374 <https://reviews.llvm.org/D98022#2609374>, @phosek wrote:

> We use `CLANG_DEFAULT_RTLIB=compiler-rt` for our toolchain and it looks like 
> after this change, two tests started failing:
> [...]
> This is presumably because both of these tests assume that `lgcc` is present 
> on the link line, but with `CLANG_DEFAULT_RTLIB=compiler-rt` that's not the 
> case anymore.

Right, yes, this is probably the correct culprit then.

I attempted to keep the behaviour as it was, but I presume the more correct 
thing to do would be to have it set `CLANG_DEFAULT_UNWINDLIB` to the empty 
string, in this case, and that would match what was done before?

Feel free to either revert or try to fix with such a change.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98022/new/

https://reviews.llvm.org/D98022

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to