mstorsjo added a subscriber: MaskRay. mstorsjo added a comment. In D98023#2606973 <https://reviews.llvm.org/D98023#2606973>, @mati865 wrote:
> I'm a bit worried about this code though: > > bool AsNeeded = LGT == LibGccType::UnspecifiedLibGcc && > !TC.getTriple().isAndroid() && > !TC.getTriple().isOSCygMing(); > > https://github.com/llvm/llvm-project/blob/0b274ed499603d30694c0b995252ab014609acf9/clang/lib/Driver/ToolChains/CommonArgs.cpp#L1413 > IIUC this change would flip it from `false` to `true` for Linux targets, > which also sounds fine on it's own but goes beyond this diff description and > seems to lack any test. Oh, you're right. Hmm, this is sure a bit entangled... @MaskRay What do you think about this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98023/new/ https://reviews.llvm.org/D98023 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
