aaron.ballman added a comment. In http://reviews.llvm.org/D19871#419954, @etienneb wrote:
> In http://reviews.llvm.org/D19871#419947, @aaron.ballman wrote: > > > Is this required for some purpose? > > > It's used in clang-tidy checkers. > > see http://reviews.llvm.org/D19841 It's good to have that context in a review for functionality that isn't part of the proposed patch. :-) Looking at the other patch, I would prefer to keep this matcher narrowed to just clang-tidy unless you can also solve how to expose it via the dynamic registry so that it can be used by tools like clang-query. > > I'm not keen on adding new AST matchers that we cannot expose via the > > dynamic API, so I would prefer to solve that problem if we want to add this > > matcher. > > > > > > Also, be sure to regenerate the documentation from dump_ast_matchers.py > > > Ah, this is the way to generate the doc. Thanks :) You're welcome! http://reviews.llvm.org/D19871 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
