LuoYuanke added inline comments.
================
Comment at: llvm/lib/Target/X86/X86LowerAMXIntrinsics.cpp:82
+ DTU.applyUpdatesPermissive({
+ {DominatorTree::Delete, Preheader, Tmp},
+ {DominatorTree::Insert, Header, Body},
----------------
pengfei wrote:
> Do we need to remove the successor? Isn't it still being dominated?
I think this is to remove edge from preheader to tmp, because we insert a loop
between them.
================
Comment at: llvm/test/CodeGen/X86/AMX/amx-low-intrinsics-no-amx-bitcast.ll:1
+; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
+; RUN: opt -mtriple=x86_64 -lower-amx-intrinsics %s -S | FileCheck %s
----------------
pengfei wrote:
> I think we should move the files to llvm/test/Transforms/
Not sure about it. Our .cpp code is under lib/Target/X86/ folder.
================
Comment at: llvm/test/CodeGen/X86/AMX/amx-type.ll:2
; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
-; RUN: opt -lower-amx-type %s -S | FileCheck %s
+; RUN: opt --codegen-opt-level=2 -mtriple=x86_64 -lower-amx-type %s -S |
FileCheck %s
----------------
pengfei wrote:
> Why adding this? Is it O2 by default?
I think this is to test with opt level 2 this pass do nothing.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D93594/new/
https://reviews.llvm.org/D93594
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
