kito-cheng added inline comments.
================ Comment at: clang/test/Driver/riscv64-toolchain.c:158 +// RUN: %clang %s \ +// RUN: -target riscv64-unknown-elf \ +// RUN: --gcc-toolchain=%S/Inputs/multilib_riscv64_elf_sdk \ ---------------- MaskRay wrote: > Hmm. I happened to have posted > https://lists.llvm.org/pipermail/cfe-dev/2021-March/067820.html about how > folks use --gcc-toolchain. > > Is this an useful option on non-riscv host? `--gcc-toolchain` should be useful for non-pure LLVM toolchain especially for bare-metal cross toolchain, IIRC GCC_INSTALL_PREFIX is not support relative path well like DEFAULT_SYSROOT[1], so I think this option is necessary even we have GCC_INSTALL_PREFIX cmake option. [1] https://reviews.llvm.org/D76653 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97916/new/ https://reviews.llvm.org/D97916 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
