tejohnson added inline comments.
================ Comment at: clang/test/CodeGen/thinlto-inline-asm2.c:10 + +//--- a.c +const char *ref() { ---------------- Is this other file needed for the test? ================ Comment at: llvm/test/ThinLTO/X86/asm.ll:11 +; NM-NOT: {{.}} +; NM: ---------------- T ref +; NM-NOT: {{.}} ---------------- MaskRay wrote: > tejohnson wrote: > > What is the behavior here without this patch? > This is not changed. `ff_h264_cabac_tables` is not in the IR symbol table. Same question here - is this file needed to test the handling of the llvm.compiler.used in the other file? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97755/new/ https://reviews.llvm.org/D97755 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits