ahatanak planned changes to this revision. ahatanak added a comment. On second thought, I think we should emit a call to `@llvm.objc.retain` instead of a call to `@llvm.objc.retainAutoreleasedReturnValue`. I think we might want to remove ARC optimizer's code that converts calls to `@llvm.objc.retainAutoreleasedReturnValue` to calls to `@llvm.objc.retain` since it sometimes does the transformation when it shouldn't and we won't need that transformation once we switch to using the `clang.arc.attachedcall` operand bundle.
Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97824/new/ https://reviews.llvm.org/D97824 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
