pengfei added a comment.

Thanks for the review.



================
Comment at: clang/lib/Driver/ToolChains/MSVC.cpp:499
       CmdArgs.push_back("-guard:cf-");
+    } else if (GuardArgs.equals_lower("ehcont")) {
+      CmdArgs.push_back("/guard:ehcont");
----------------
rnk wrote:
> This is gone now, btw
Sorry, I don't understand by the mean "gone"? The check for cf is still there 
after I rebased, I think we should do for ehcont too.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96709/new/

https://reviews.llvm.org/D96709

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to