lebedev.ri added a comment.

Once again, can we please split this into two patches?
I'm quite happy with the `DescribeBasicIncrements` stuff, that can be merged 
right now.

But i'm not quite sold on the macro stuff. We don't have that for 
readability-function-size,
nor does the CC spec say anything about macros, nor do other implementations 
allow to discount them.
To take it to extreme, one potentially could wrap the entire function into a 
macro and instantiate it once,
and end up with a zero complexity, even though it's obviously not so..


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96281/new/

https://reviews.llvm.org/D96281

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to