aaron.ballman added inline comments.

================
Comment at: 
clang-tools-extra/test/clang-tidy/checkers/readability-uniqueptr-delete-release.cpp:40
+
+  delete (P2.release());
+  // CHECK-MESSAGES-NULLPTR: :[[@LINE-1]]:3: warning: prefer '= nullptr'
----------------
njames93 wrote:
> aaron.ballman wrote:
> > Not that I expect this to come up particularly often, but, how about: 
> > `delete (P2.release)();`
> I don't think Im gonna worry about those given how infrequently bound member 
> functions are used.
I'm fine with that, but it does come up from people who loathe ADL shenanigans. 
That said, if it comes up *here*, I'd be surprised.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97630/new/

https://reviews.llvm.org/D97630

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to