awarzynski added inline comments.
================ Comment at: clang/include/clang/Driver/Options.td:4280-4281 HelpText<"Dump provenance">; +def fdebug_module_writer : Flag<["-"],"fdebug-module-writer">, + HelpText<"Enables showing debug messages while writing module files.">; ---------------- [nit] The convention here seems to be: no `.` at the end [nit] Perhaps a bit shorter: `Enable debug messages while writhing module files`? ================ Comment at: flang/include/flang/Frontend/CompilerInvocation.h:73-74 + bool debugModuleDir_ = false; + + public: ---------------- [nit] One empty line instead of 2 ================ Comment at: flang/lib/Frontend/CompilerInvocation.cpp:297 clang::DiagnosticsEngine &diags) { - + + // -J/module-dir option ---------------- Unrelated change CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96875/new/ https://reviews.llvm.org/D96875 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits