alexfh added a comment. In D97288#2581908 <https://reviews.llvm.org/D97288#2581908>, @sammccall wrote:
> How strong is the need for this? > This adds complexity to a widely implemented and used interface, and the > combination of virtual + default parameters can be at least a little > confusing. That's a fair question. Indeed, this is needed quire rarely, and I just removed what would be a use case for from our internal code. Even `Status::isSymlink` is almost exclusively used in tests. The main motivation for the patch is to make the `FileSystem::status()` API more aligned with `sys::fs::status()`, and allow `Status::isSymlink` to fulfil its purpose for `Status` instances coming from `FileSystem::status()`. Also a way to avoid confusion in the future. Definitely not a practical need right now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97288/new/ https://reviews.llvm.org/D97288 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
