erichkeane added a comment. In D97324#2583286 <https://reviews.llvm.org/D97324#2583286>, @jyknight wrote:
> I can imagine there being some cases where these could theoretically be > useful. > > But if you've tested this change and it doesn't cause build failures with any > existing uses of TrailingObjects in llvm-project, then LGTM. Thanks! I ran into the problem because I had a function that returned by reference, and stored a copy, which worked silently. Then, during runtime, I obviously got nonsense. Hopefully these are sufficient to prevent that from being a problem for others in the future. I'd built ahead of time (and done check-all), so I'm quite confident that this won't cause issues. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97324/new/ https://reviews.llvm.org/D97324 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
