aeubanks added a comment. I guess this is fine. I'm worried that various OptimizerLastEPCallbacks will only expect to be run once, and adding a special case of not adding those callbacks during thinlto post link will be confusing for other uses of OptimizerLastEPCallbacks, but maybe it won't be so bad
================ Comment at: clang/lib/CodeGen/BackendUtil.cpp:1305 + // (used in testing in a distributed build environment). + bool SkipThinLTOPostLink = !CodeGenOpts.ThinLTOIndexFile.empty(); + // If so drop any the type test assume sequences inserted for whole program ---------------- what about just `IsThinLTOPostLink`? The `Skip` implies that we should skip ThinLTO post link, not that we should skip the passes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96320/new/ https://reviews.llvm.org/D96320 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
