steveire added a comment. In D96665#2579422 <https://reviews.llvm.org/D96665#2579422>, @steveire wrote:
> In D96665#2578635 <https://reviews.llvm.org/D96665#2578635>, @goncharov wrote: > >> Hi @steveire! Sorry but I reverted this revert. Could you please give some >> context of "discussed elsewhere" and "pre-existing unit test for the >> matcher"? @aaron.ballman for cc > > @njames93 didn't realize that the offending commits were from 2019, as I > wrote in the comment. That's what I told him "elsewhere". > > I plan to re-apply this revert. If you have a reason I shouldn't do that, > please say what it is. @goncharov I see you already re-landed it. In future please open review requests for things like this to avoid confusion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96665/new/ https://reviews.llvm.org/D96665 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits