mibintc added inline comments.
================ Comment at: clang/lib/Basic/SanitizerBlacklist.cpp:15 #include "clang/Basic/FileManager.h" +#include "clang/Basic/NoSanitizeList.h" #include "clang/Basic/SanitizerSpecialCaseList.h" ---------------- vitalybuka wrote: > dexonsmith wrote: > > vitalybuka wrote: > > > Own header should go first. > > Probably a good idea to move the file > > `clang/lib/Basic/SanitizerBlacklist.cpp` at the same time as its header > > `clang/include/clang/Basic/SanitizerBlacklist.h`; then you won't be > > fighting clang-format on this. > Oh, right, I didn't noticed that. It needs to be fixed. Oops, good catch, thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96974/new/ https://reviews.llvm.org/D96974 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
